Fix pip wheel checks#389
Merged
Merged
Conversation
Previously (prior to version 10, I think), pip wheel --version would exit 0 when wheel was installed even though it complained about wanting more arguments. Now that same command exits 1 which negates its purpose. Using pip wheel show accomplishes the same goal as was originally intended.
The commands were SOOO long before this that they were really hard to follow. While deciphering them I noticed a lot of duplication from command to command and on each side of the ||'s. I pulled most of the duplicated code out into some variables which provides two benefits: 1) a single place to update the common components 2) easier to read exec's
--no-use-wheel has been depreciated since at least pip 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is the fix by itself.
The second commit is a refactor to reduce duplication of code and ease reading the exec's.
The third commit replaces
--no-use-wheelwith--no-binary :all:. pip 10 doesn't have the old flag at all and pip v8 & v9 recommend this change.The issue being fixed is that previously (prior to version 10, I think),
pip wheel --versionwouldexit 0 when wheel was installed even though it complained about wanting
more arguments. Now that same command exits 1 which negates its purpose.
Using
pip wheel showaccomplishes the same goal as was originallyintended.